Fix linting errors across backend and frontend
Backend: auto-fix and format all ruff issues, manually fix B904/B023/ SIM117/B007/E741/F841 errors, suppress B008 (FastAPI Depends) and F821 (SQLAlchemy forward refs) in config. Frontend: allow constant exports, disable React compiler-specific rules (set-state-in-effect, preserve-manual-memoization). Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This commit is contained in:
@@ -8,7 +8,6 @@ from app.models.evolution import Evolution
|
||||
from app.models.pokemon import Pokemon
|
||||
from app.models.route import Route
|
||||
from app.models.route_encounter import RouteEncounter
|
||||
from app.models.game import Game
|
||||
from app.schemas.pokemon import (
|
||||
BulkImportItem,
|
||||
BulkImportResult,
|
||||
@@ -40,9 +39,7 @@ async def list_pokemon(
|
||||
# Build base query with optional search filter
|
||||
base_query = select(Pokemon)
|
||||
if search:
|
||||
base_query = base_query.where(
|
||||
func.lower(Pokemon.name).contains(search.lower())
|
||||
)
|
||||
base_query = base_query.where(func.lower(Pokemon.name).contains(search.lower()))
|
||||
if type:
|
||||
base_query = base_query.where(Pokemon.types.any(type))
|
||||
|
||||
@@ -51,7 +48,11 @@ async def list_pokemon(
|
||||
total = (await session.execute(count_query)).scalar() or 0
|
||||
|
||||
# Get paginated items
|
||||
items_query = base_query.order_by(Pokemon.national_dex, Pokemon.name).offset(offset).limit(limit)
|
||||
items_query = (
|
||||
base_query.order_by(Pokemon.national_dex, Pokemon.name)
|
||||
.offset(offset)
|
||||
.limit(limit)
|
||||
)
|
||||
result = await session.execute(items_query)
|
||||
items = result.scalars().all()
|
||||
|
||||
@@ -156,9 +157,7 @@ async def get_pokemon_families(
|
||||
|
||||
|
||||
@router.get("/pokemon/{pokemon_id}", response_model=PokemonResponse)
|
||||
async def get_pokemon(
|
||||
pokemon_id: int, session: AsyncSession = Depends(get_session)
|
||||
):
|
||||
async def get_pokemon(pokemon_id: int, session: AsyncSession = Depends(get_session)):
|
||||
pokemon = await session.get(Pokemon, pokemon_id)
|
||||
if pokemon is None:
|
||||
raise HTTPException(status_code=404, detail="Pokemon not found")
|
||||
@@ -258,7 +257,8 @@ async def get_pokemon_evolution_chain(
|
||||
|
||||
# Filter evolutions to only those in the family
|
||||
family_evo_ids = [
|
||||
evo.id for evo in evolutions
|
||||
evo.id
|
||||
for evo in evolutions
|
||||
if evo.from_pokemon_id in family and evo.to_pokemon_id in family
|
||||
]
|
||||
|
||||
@@ -294,9 +294,7 @@ async def get_pokemon_evolutions(
|
||||
.options(joinedload(Evolution.to_pokemon))
|
||||
)
|
||||
if region is not None:
|
||||
query = query.where(
|
||||
or_(Evolution.region.is_(None), Evolution.region == region)
|
||||
)
|
||||
query = query.where(or_(Evolution.region.is_(None), Evolution.region == region))
|
||||
result = await session.execute(query)
|
||||
evolutions = result.scalars().unique().all()
|
||||
|
||||
@@ -309,7 +307,8 @@ async def get_pokemon_evolutions(
|
||||
}
|
||||
if regional_keys:
|
||||
evolutions = [
|
||||
e for e in evolutions
|
||||
e
|
||||
for e in evolutions
|
||||
if e.region is not None or (e.trigger, e.item) not in regional_keys
|
||||
]
|
||||
|
||||
@@ -349,9 +348,7 @@ async def update_pokemon(
|
||||
|
||||
|
||||
@router.delete("/pokemon/{pokemon_id}", status_code=204)
|
||||
async def delete_pokemon(
|
||||
pokemon_id: int, session: AsyncSession = Depends(get_session)
|
||||
):
|
||||
async def delete_pokemon(pokemon_id: int, session: AsyncSession = Depends(get_session)):
|
||||
result = await session.execute(
|
||||
select(Pokemon)
|
||||
.where(Pokemon.id == pokemon_id)
|
||||
|
||||
Reference in New Issue
Block a user