pokemon/nuzlocke-tracker
1
1
Fork 0
Code Issues Pull Requests 1 Actions Packages Projects Releases Wiki Activity

Fix FK violations when pruning stale routes #32

Merged
TheFurya merged 2 commits from develop into main 2026-02-21 17:57:00 +01:00
Conversation 0 Commits 2 Files Changed 4 +72 -36
TheFurya commented 2026-02-21 17:51:22 +01:00
Owner
Copy Link

Summary

  • Bulk DELETE FROM routes bypasses ORM-level cascades, causing FK violations on route_encounters and boss_battles
  • Manually delete route_encounters and nullify boss_battle.after_route_id before deleting stale routes
  • Skip pruning routes that are referenced by user encounters

Test plan

  • Run python -m app.seeds --prune against a database with stale routes and verify it completes without FK errors
## Summary - Bulk `DELETE FROM routes` bypasses ORM-level cascades, causing FK violations on `route_encounters` and `boss_battles` - Manually delete `route_encounters` and nullify `boss_battle.after_route_id` before deleting stale routes - Skip pruning routes that are referenced by user encounters ## Test plan - [ ] Run `python -m app.seeds --prune` against a database with stale routes and verify it completes without FK errors
TheFurya added 1 commit 2026-02-21 17:51:23 +01:00
Fix FK violations when pruning stale routes
Some checks failed
CI / backend-tests (push) Successful in 26s
Details
CI / frontend-tests (push) Successful in 27s
Details
CI / e2e-tests (push) Has been cancelled
Details
3b63285bd1 
Bulk delete bypasses ORM-level cascades, so manually delete
route_encounters, nullify boss_battle.after_route_id, and skip
routes referenced by user encounters before deleting stale routes.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
TheFurya added 1 commit 2026-02-21 17:54:37 +01:00
Split e2e tests into manual workflow_dispatch workflow
All checks were successful
CI / frontend-tests (push) Successful in 27s
Details
CI / backend-tests (push) Successful in 26s
Details
1513bb3658 
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
TheFurya merged commit 321b940398 into main 2026-02-21 17:57:00 +01:00
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
No items
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
TheFurya renovate
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: pokemon/nuzlocke-tracker#32
Delete Branch "develop"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?